Add support for verifying reply addresses - #172
Conversation
--------- Co-authored-by: sa-linetco <sa-linetco@users.noreply.github.com>
vb-linetco
changed the title
|
Hey @danielzzz , when you get a chance, could you please take a look at this PR? Let me know if you spot anything that needs changing. Thanks! |
|
Hi, after reading your implementation, can you rename the option to be A side note. I have update the underlying node engine. You may need to rebuild this project development accordingly. |
|
@mondwan I've updated the PR as you requested. If there are any issues with my changes, please let me know. |
|
@vb-linetco sorry for having this in the backlog for so long 🙏 , I will look into asap. |
Substring IPs like 18.8.8.8 still count as 8.8.8.8, ignored replies still keep footer stats, and PingConfig is missing the option.
|
@vb-linetco please rebase on this branch if possible: I found some edge cases, when your solution would break. thank you! |
Good catch, working on the fix, thanks for the review |
|
thanks for your contribution @vb-linetco |
3 participants
On linux platform when using ping from iptuils there is an issue when some misbehaving hosts or other network devices may respond to a ping with a different address. The ping implementation of
iputilsunfortunately regards those as valid replies and prints the timing information nevertheless see: comparison of source address with target and the corresponding statistics outputWe observed an issues with host being detected as alive when another misbehaving hosts replies to the echo requests. This PR Addresses the issue by adding an option to enable verification of reply addresses.